Skip to content

Fix: memoize Action#response to prevent duplicate HTTP requests#55

Merged
ValdemarKobelis merged 1 commit intomasterfrom
reduce_http_request_count
Feb 24, 2026
Merged

Fix: memoize Action#response to prevent duplicate HTTP requests#55
ValdemarKobelis merged 1 commit intomasterfrom
reduce_http_request_count

Conversation

@ValdemarKobelis
Copy link
Copy Markdown
Contributor

Summary

  • Memoize Action#response to avoid redundant HTTP requests
  • RelationProxy#find was calling action.response twice per call, doubling HTTP traffic for every .find() invocation

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml
Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml
Warning: unrecognized cop RSpec/MultipleMemoizedHelpers found in .rubocop.yml
Error: RuboCop found unknown Ruby version 3.1 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7

@ValdemarKobelis ValdemarKobelis requested review from a team, jusmat and povilasjurcys February 24, 2026 06:46
@ValdemarKobelis ValdemarKobelis requested a review from a team February 24, 2026 07:38
@ValdemarKobelis ValdemarKobelis merged commit 3c34b9d into master Feb 24, 2026
7 checks passed
@ValdemarKobelis ValdemarKobelis deleted the reduce_http_request_count branch February 24, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants