Fix: memoize Action#response to prevent duplicate HTTP requests#55
Merged
ValdemarKobelis merged 1 commit intomasterfrom Feb 24, 2026
Merged
Fix: memoize Action#response to prevent duplicate HTTP requests#55ValdemarKobelis merged 1 commit intomasterfrom
ValdemarKobelis merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml
Warning: unrecognized cop Naming/MethodParameterName found in .rubocop.yml Warning: unrecognized cop RSpec/MultipleMemoizedHelpers found in .rubocop.yml Error: RuboCop found unknown Ruby version 3.1 in `TargetRubyVersion` parameter (in .rubocop.yml). Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
jusmat
approved these changes
Feb 24, 2026
matas-zanevicius
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Action#responseto avoid redundant HTTP requestsRelationProxy#findwas callingaction.responsetwice per call, doubling HTTP traffic for every.find()invocation